Fixing #2940. Upgrading to use JUnit 5#5071
Merged
kcondon merged 3 commits intoIQSS:developfrom Sep 27, 2018
Merged
Conversation
5 tasks
Closed
poikilotherm
force-pushed
the
2940-upgrade-junit4
branch
2 times, most recently
from
44eef80 to
542da63
Compare
matthew-a-dunlap
approved these changes
Sep 24, 2018
Contributor
|
@poikilotherm That IT failures looks like the one fixed in #5070 |
Contributor
Author
|
@pameyer Yes indeed. Shall we wait for that or would you guys like to merge? I can rebase again, too. |
…mbined with JUnit 4.12 Vintage Engine. This allows us to have both versions active in parallel and make the migration easier. Fixed `IngestableDataCheckerTest.testTestSAVformat()` unit test, which was failing with 4.12. This was not an engine fault but a mistake within the test case itself.
…{argLine}' in surefire plugin argLine option.
poikilotherm
force-pushed
the
2940-upgrade-junit4
branch
from
542da63 to
82ed295
Compare
Contributor
|
@poikilotherm If you want to rebase that would be great! |
Contributor
Author
|
Already done 😉 |
1 task
5 tasks
pdurbin
added this to the
4.9.3 - Optional File PIDs, Initial Internationalization Work milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will use JUnit 5 with Jupiter 5.3 engine combined with JUnit 4.12 Vintage Engine.
This allows us to have both versions active in parallel and make the migration easier.
There is still an issue with the IT tests (output from only running the failing test, don't get fooled by the counts):
This does not seem to be JUnit related, so maybe ignore this for this PR?
Related Issues
Pull Request Checklist
IngestableDataCheckerTest.testTestSAVformat()unit test, which was failing with 4.12.This was not an engine fault but a mistake within the test case itself.