Conversation
…mbined with JUnit 4.12 Vintage Engine. This allows us to have both versions active in parallel and make the migration easier. Fixed `IngestableDataCheckerTest.testTestSAVformat()` unit test, which was failing with 4.12. This was not an engine fault but a mistake within the test case itself.
…{argLine}' in surefire plugin argLine option.
* Add CheckStyle configuration with most things commented out. * Enabled Braces, FileTab and NewlineAtEnd checking * Enhancing CI by adding stages to TravisCI configuration * Do not run `mvn install` from TravisCI default, only install Maven dependencies (keep build log cleaner)
michbarsinai
left a comment
michbarsinai
left a comment
There was a problem hiding this comment.
Looks good. I think we need to have a conversation on which checks to enable, but this is a good start.
|
@poikilotherm thank you very much for this pull request! I used it as the basis for pull request #5106 which is much smaller and what I feel is more of the "baby step" we need at this point. The build doesn't fail on violations. I simply offer some instructions on how to use Checkstyle to check your code if you feel like it. I'm closing this pull request in favor of that one. |
|
Hi @pdurbin - sure. 👍 Better baby steps than nothing 😉 Whatever works for your team and how you can get peoples mind best changed to adapt to standard tooling and development routines. Maybe you can reconsider my Travis CI configuration to get that |
3 participants
As discussed during the community call, I gave it a shot 😉 . Please take this as a kind suggestion and discuss internally.
I took my default CheckStyle config first, which lead to about ~65k validations. The CheckStyle rules need to be tweaked to your "house style". If you want, I can help with this. Nearly everything is possible - this is a very mature tool.
If you want to try this: just clone my feature branch and activate the maven profile
-Pvalidate. Enjoy! Or look into the Travis CI output for this.Enhanced the Travis CI config too. If you want this in a separate issue/PR please comment, I'm willing to split things... 😄
(And please ignore the three other commits. This is - of course - based on work from #2940 and not yet merged #5071)
Related Issues
Pull Request Checklist