Conversation
pdurbin
reviewed
Sep 19, 2018
Member
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
This looks fine but we should should think about a fix for phoenix too. Sometimes I put these settings changes in the tests themselves, in HarvestingServerIT.java in this case.
Contributor
Author
|
@pdurbin Using the setting in the IT sounds good a good idea. |
Closed
5 tasks
pdurbin
added this to the
4.9.3 - Optional File PIDs, Initial Internationalization Work milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Contributors
Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!
Related Issues
does not address the
edu.harvard.iq.dataverse.api.FileMetadataIT.setUpDataversefailures from jenkins, since I'm not able to reproduce them.Pull Request Checklist