#5245 - fix global id url parsing when parsing OAI

[tcoupin]

Related Issues

• connects to Harvesting OAI with URL identifier fail #5245 Harvesting OAI with URL identifier fail

Pull Request Checklist

• Unit tests completed
• Integration tests: None
• Deployment requirements, SQL updates, Solr updates, etc.: None
• Documentation completed
• Merged latest from "develop" branch and resolved conflicts

[coveralls]

Coverage decreased (-0.0006%) to 17.646% when pulling 73703f8 on tcoupin:5245-globalid-url-harvest-oaidc into 38851fa on IQSS:develop.

[pameyer]

on 756fa24:

[ERROR] Failures: 
[ERROR]   FileMetadataIT.testJsonParserWithDirectoryLabels Multiple Failures (2 failures)
        Expected status code <201> doesn't match actual status code <500>.

        Expected status code <200> doesn't match actual status code <404>.

[INFO] 
[ERROR] Tests run: 79, Failures: 1, Errors: 0, Skipped: 1

[tcoupin]

@pameyer I can not reproduce the test fail:

$ mvn test -P all-unit-tests
...
[WARNING] Tests run: 564, Failures: 0, Errors: 0, Skipped: 6
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19.443 s
[INFO] Finished at: 2018-10-31T06:26:13Z
[INFO] ------------------------------------------------------------------------

It's the same on Travis Build https://travis-ci.org/IQSS/dataverse/builds/448350282#L6777

[pdurbin]

@tcoupin hi! Travis is only executing unit tests. We also have integration tests but we have not automated this very well. Running them requires effort on the part of each developer.

@pameyer is using Docker to run the integration tests. Please see http://guides.dataverse.org/en/4.9.4/developers/testing.html#running-the-full-api-test-suite-using-docker

[tcoupin]

on 756fa24 using docker-aio

[WARNING] Tests run: 79, Failures: 0, Errors: 0, Skipped: 1

It does not seem to be related to this PR since build 289 report the same failure on develop branch.

[pdurbin]

@tcoupin well, the failure we're seeing on phoenix has to do with account conversion: #5260

[landreev]

One small thing:
Could you please remove line 425 - since the comment is no longer needed, or valid. - Thanks

[tcoupin]

Merge done, comment removed