Skip to content

#5245 - fix global id url parsing when parsing OAI #5247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kcondon merged 3 commits into from
Jan 7, 2019
Merged

#5245 - fix global id url parsing when parsing OAI #5247

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
756fa24
#5245 - fix global id url parsing when parsing OAI
tcoupin Oct 30, 2018
7ca17f4
Merge branch 'develop' into 5245-globalid-url-harvest-oaidc
tcoupin Jan 7, 2019
73703f8
Remove useless comment
tcoupin Jan 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/main/java/edu/harvard/iq/dataverse/api/imports/ImportGenericServiceBean.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,16 +411,17 @@ private String reassignIdentifierAsGlobalId(String identifierString, DatasetDTO
if (identifierString.startsWith(GlobalId.HDL_RESOLVER_URL)) {
logger.fine("Processing Handle identifier formatted as a resolver URL: "+identifierString);
protocol = GlobalId.HDL_PROTOCOL;
index1 = GlobalId.HDL_RESOLVER_URL.length() - 1;
index1 = GlobalId.HDL_RESOLVER_URL.length() - 1;
index2 = identifierString.indexOf("/", index1 + 1);
} else if (identifierString.startsWith(GlobalId.DOI_RESOLVER_URL)) {
logger.fine("Processing DOI identifier formatted as a resolver URL: "+identifierString);
protocol = GlobalId.DOI_PROTOCOL;
index1 = GlobalId.DOI_RESOLVER_URL.length() - 1;
index2 = identifierString.indexOf("/", index1 + 1);
} else {
logger.warning("HTTP Url in supplied as the identifier is neither a Handle nor DOI resolver: "+identifierString);
return null;
}
// index2 was already found as the index of '/' - so it's still good.
} else {
logger.warning("Unknown identifier format: "+identifierString);
return null;
Expand Down