Conversation
|
This PR includes changes for 4 different issues. As they were all metrics related, they were combined. These are the code changes:
Its also worth noting that for the homepage to run optimally, the metrics cache timeout option should be set to update daily. The default is every 7 days. In terms of testing, all dataset/file endpoints would benefit from being retested as they were touched the most. Other metrics endpoints could be tested as well tho the changes that effect them are more generic. |
sekmiller
left a comment
There was a problem hiding this comment.
Maybe make metricName static strings kept in one place?
sekmiller
left a comment
There was a problem hiding this comment.
Also, DatasetsToMonth isn't coming close to matching what we see from the counts from Solr. Not sure why, it may be based on being logged in or not and permissions that Sold counts take into consideration. I was expecting the number to be close to what you would see if you weren't logged in.
We will try to add this again later. Is it not actually required.
… harvested datasets (or both). (ref #5445)
Related Issues
Pull Request Checklist