Skip to content

QDR-982 - sort by category#5485

Closed
qqmyers wants to merge 1 commit intoIQSS:developfrom
QualitativeDataRepository:4959-Allow_installations_to_determine_order_of_files_on_Dataset_page
Closed

QDR-982 - sort by category#5485
qqmyers wants to merge 1 commit intoIQSS:developfrom
QualitativeDataRepository:4959-Allow_installations_to_determine_order_of_files_on_Dataset_page

Conversation

@qqmyers
Copy link
Member

@qqmyers qqmyers commented Jan 23, 2019

Conflicts:
src/main/java/edu/harvard/iq/dataverse/settings/SettingsServiceBean.java

New Contributors

Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!

Related Issues

Pull Request Checklist

Conflicts:
	src/main/java/edu/harvard/iq/dataverse/settings/SettingsServiceBean.java
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 17.35% when pulling 1a169d2 on QualitativeDataRepository:4959-Allow_installations_to_determine_order_of_files_on_Dataset_page into d022e46 on IQSS:develop.

@djbrooke
Copy link
Contributor

djbrooke commented Feb 6, 2019

Closing per comments in #4959:

"Hi @qqmyers and all -- since we have some user testing efforts related to sort in the next few weeks, we’ll use that opportunity to learn more about what other scenarios are in play for default sort options. I’m going to close out this PR for now as I don’t want to take action until we have some more information about what’s best for as many default sort scenarios as possible. As you and others have mentioned, the user-driven option can be implemented independently of this, and we’ll plan to do that (cc: @TaniaSchlatter)."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants