IQSS/4959-Support-By-Category-and-Folder-Grouping#9204
Merged
kcondon merged 22 commits intoIQSS:developfrom May 2, 2023
Conversation
Conflicts: src/main/java/edu/harvard/iq/dataverse/settings/SettingsServiceBean.java
4959-Allow_installations_to_determine_order_of_files_on_Dataset_page
4959-Allow_installations_to_determine_order_of_files_on_Dataset_page
…_Dataset_page' of https://github.com/QualitativeDataRepository/dataverse.git into 4959-Allow_installations_to_determine_order_of_files_on_Dataset_page
4959-Allow_installations_to_determine_order_of_files_on_Dataset_page
IQSS/7349-4_creator_updates
…ions_to_determine_order_of_files_on_Dataset_page
…ions_to_determine_order_of_files_on_Dataset_page
…ions_to_determine_order_of_files_on_Dataset_page
…_Dataset_page' of https://github.com/QualitativeDataRepository/dataverse.git into 4959-Allow_installations_to_determine_order_of_files_on_Dataset_page
…ions_to_determine_order_of_files_on_Dataset_page
rtreacy
approved these changes
Apr 26, 2023
Contributor
rtreacy
left a comment
There was a problem hiding this comment.
Checked as per instructions. Both checkboxes checked, unchecked Group By Folder, Grouped By Tag in all combinations. Checked Tree view always maintains folder order
Contributor
|
Issues found: |
Member
Wait, is a new database setting slipping in? Shouldn't this be MPCONFIG? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR is an update to the original work in #5485 from QDR in 2019 that added a 'Group by Folder' option for the main dataset file table and an optional 'Goup By Category' option. These work in consort with the main sort options and do a presort/grouping of the files by Category tag (e.g. Documentation, Data, Code, custom tags) and/or Folder before the alphabetical, by age, etc. sorting is done.
Which issue(s) this PR closes:
Closes #4959
Closes #6933
Special notes for your reviewer:
The original work has been in production in QDR since 2019 but was dropped from consideration by IQSS in anticipation of further analysis of other possible options. Since then JHU and ASU have requested this functionality and JHU has supported updating the original branch via GDCC.
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:

The image shows the two new Group-By-Folder and Group-By-Tag checkbox selectors and shows some of the effect of the tag sort - the second file with the Data tag would normally be third in alphabetical order but has been pulled up to be before untagged files. (Not shown - a file in the /test sub-folder is now last in the list instead of in the top 3 files due to the group-by-folder setting.)
Is there a release notes update needed for this change?: in the PR
Additional documentation: