Internationalization - Facet Category/Facet Label#5618
Internationalization - Facet Category/Facet Label#5618JayanthyChengan wants to merge 15 commits intoIQSS:developfrom
Conversation
…facetDisplay # Conflicts: # src/main/java/Bundle_fr.properties
…erse-facetDisplay
…facetDisplay # Conflicts: # src/main/java/Bundle_fr.properties
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
I left some comments and questions inline.
| @@ -8,8 +8,8 @@ datasets=Ensembles de donn | |||
| newDataset=Nouvel ensemble de donn�es | |||
There was a problem hiding this comment.
When will this entire Bundle_fr.properties file be removed? It's the plan for installations who want French support to get the Bundle_fr.properties file from https://github.com/GlobalDataverseCommunityConsortium/dataverse-language-packs ?
There was a problem hiding this comment.
@pdurbin - Yes, I would like to create a separate issue to remove all french language files and Bundle_zh_CN.properties from codebase. Also to move all the English property files into a specific folder. Eg: under src/main/java/english/*.properties , so this folder can be synchronized automatically (through Jenkins setup) to the English folder in dataverse-language-packs repository. Later, translators can work for other languages. Please add your comments. Thanks
|
|
||
| #astrophysics | ||
| Image=Image | ||
| Mosaic=Mosaic |
There was a problem hiding this comment.
Do we really want strings that were formerly in astrophysics.tsv (for example) in the main Bundle.properties file? Should they go in src/main/java/astrophysics.properties instead? Also, does metadatacustomization.rst need to be updated to mention facets and where to put the strings when creating a custom metadata block?
There was a problem hiding this comment.
@pdurbin - The key added to the bundle.properties are the values returned from solr for facets. Is there any way to identify which metadata property file it corresponds to?
|
closing in favor of #5697 |
5 participants
For both facet categories and Facet labels, key/value pairs are added to bundle files based on what solr returns and fetched into UI ( search-include-fragment.xhtml )
Related Issues