Added request access popup to file pg [ref #4897]

[mheppler]

Related Issues

• Request Access: button does not launch popup if logged in and request from file landing page. #4897 Request Access: button does not launch popup if logged in and request from file landing page.

Pull Request Checklist

• Unit tests completed
• Integration tests: None
• Deployment requirements, SQL updates, Solr updates, etc.: None
• Documentation completed
• Merged latest from "develop" branch and resolved conflicts

[coveralls]

Coverage remained the same at 19.676% when pulling ab03bb2 on 4897-file-pg-request-access-fix into 3dde216 on develop.

[kcondon]

@mheppler Request Access popup no longer sends request to admin from either dataset or file landing page. Works in develop. See dvn-build for develop, internal for your branch

[mheppler]

Removed a snippet of code from the file pg that seemed to have been an unintentional rogue pasting of ui:param components outside of the dialogs they were intended to be included in.

Unfortunately, these rogue lines of code did not change the behavior of the Request Access btns for me in my localhost. The buttons on the file pg and dataset pg all worked as expected, sending notifications to the dataverse admin through the system (no email server is setup for my localhost, so the server log complains about that).

Taking a look at the behavior of this branch on dataverse-internal, I noticed the Request Access btn works as expected on the file pg (see attachments), and intermittently on the dataset pg.

While I am not sure if cleaning up the rogue code snippet changes anything, maybe the rogue popup btns on the dataset pg, reported in #5958 have something to do with the intermittent behavior of the Request Access btn.

@kcondon -- happy to update this branch with develop once that gets merge, if you want to put off testing this again.

[kcondon]

@mheppler does request access button change state to access requested and the actual username appear as a request under the files permissions?

[mheppler]

@kcondon Yes. See attached screenshots showing both.

[kcondon]

@mheppler was able to reproduce it: it happens when extra accept/cancel buttons appear at bottom of dataset due to this bug: #5958 So, let's fix/merge that one before retesting and merging this one.

[mheppler]

Merged the latest and greatest from develop (including #5958 dataset pg btn bug fixes), and pushed those changes to this branch. Confirmed the Request Access btn function on datasets that previously had the rogue Accept and Cancel btns at the bottom of the pg.