ingest now completes, fix assertions #6322

[pdurbin]

partial solution for #6322

Here's how the output looks now, and I changed the assertions to match:

assert from line 337

{
    "status": "OK",
    "data": {
        "notifications": [
            {
                "id": 818,
                "type": "SUBMITTEDDS"
            },
            {
                "id": 816,
                "type": "INGESTCOMPLETED"
            },
            {
                "id": 815,
                "type": "SUBMITTEDDS"
            },
            {
                "id": 812,
                "type": "CREATEACC"
            }
        ]
    }
}

assert from line 389

{
    "status": "OK",
    "data": {
        "notifications": [
            {
                "id": 827,
                "type": "SUBMITTEDDS"
            },
            {
                "id": 825,
                "type": "SUBMITTEDDS"
            },
            {
                "id": 823,
                "type": "INGESTCOMPLETED"
            },
            {
                "id": 822,
                "type": "SUBMITTEDDS"
            },
            {
                "id": 819,
                "type": "CREATEACC"
            }
        ]
    }

I suppose this means that ingest is now succeeding while previously it was not. I'm not sure why. Here's the transition on phoenix where it flipped from passing to failing:

• passing: https://build.hmdc.harvard.edu:8443/job/phoenix.dataverse.org-apitest-develop/437/testReport/
• failing: https://build.hmdc.harvard.edu:8443/job/phoenix.dataverse.org-apitest-develop/438/testReport/

[coveralls]

Coverage remained the same at 19.451% when pulling 0f79235 on 6322-ingest-complete into 4470369 on develop.

[landreev]

I suppose this means that ingest is now succeeding while previously it was not.

My understanding is that the ingest was always succeeding - it's just that we now have a new ingest notification, that we didn't have before. (Was introduced in the PR merged last week - so this explains why the test started failing last week).

But the fix in this PR - adjust the expected notifications to assert - seems like the right thing to do.

[pdurbin]

it's just that we now have a new ingest notification

Right, right, from pull request #6271. Thanks, @landreev