6214 user notification following ingest

[alejandratenorio]

New Contributors

Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Note that we use the "closes" syntax below to trigger Github's automation to close the corresponding issue once the pull request is merged.

Thanks for your contribution to Dataverse!

Related Issues

• closes User Notification Following Ingest #6214

Pull Request Checklist

• Unit tests completed
• Integration tests: None
• Deployment requirements, SQL updates, Solr updates, etc.: None
• Documentation completed
• Merged latest from "develop" branch and resolved conflicts

[djbrooke]

Thanks @alejandratenorio @ricvazo!

Moving my question here from #6214... does this provide messaging for ingest failures or only successes?

[alejandratenorio]

@djbrooke,

An email is always sent, if the ingest fails a message is sent: (Error) with datafileName (src/main/java/edu/harvard/iq/dataverse/ingest/IngestMessageBean.java line 109 ).
Maybe we should add the message to Bundle.properties, what do you think?

[coveralls]

Coverage decreased (-0.01%) to 19.462% when pulling 857ab97 on CIMMYT:6214-User-Notification-Following-Ingest into 8991919 on IQSS:develop.

[djbrooke]

Hi @alejandratenorio thanks for the quick response. If you can add that to bundle.properties it would be great, since that will allow others to translate the message. I'll be able to edit the text there, so just add any text that you feel makes sense. I need to:

• Update the text in src/main/java/propertyFiles/Bundle.properties (line 190, 203, 640 at least, will wait until the ingest failure case is added)
• Add some/update information in the guides about notifications (https://github.com/IQSS/dataverse/blob/develop/doc/sphinx-guides/source/user/account.rst), added in f2b615b

I'll also assign @landreev to this issue so that we can discuss next week. We have a long weekend but we'll back in the office on Tuesday.

[alejandratenorio]

@djbrooke, yeah, we'll add it. Thank you and regards.

[alejandratenorio]

Hi @djbrooke, @ricvazo changed messages when an ingest fails.

[djbrooke]

Thanks @ricvazo @alejandratenorio

@landreev - all yours. Let me know when you've completed code review and I'll update the bundle text.