Fixed #1375 Author Identifier Additions#6358
Fixed #1375 Author Identifier Additions#6358kcondon merged 1 commit intoIQSS:developfrom mderuijter:1375-author-identifier-additions
Conversation
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
I left some comments in my review. Thanks!
| authorIdentifierScheme DAI 5 | ||
| authorIdentifierScheme ResearcherID 6 | ||
| authorIdentifierScheme ScopusID 7 | ||
| language Abkhaz 0 |
There was a problem hiding this comment.
I got curious about why the line for "Abkhaz" changed and it looks like the trailing tabs were removed:
It looks like the new lines for authorIdentifierScheme don't have trailing tabs either. I assume this is fine.
It would be nice to add a file under "doc/release-notes" to explain to installations what they should do to add the new values. My understanding is that they should re-run the curl command for the citation.tsv file. This process of writing release notes is described at http://guides.dataverse.org/en/4.17/developers/making-releases.html#write-release-notes
Finally, I believe this pull request closes #3169 so the description should probably be change to that (instead of "related"). On his way out the door, @djbrooke indicated that he might want to let @Venki18 make the change himself during Danny's visit to NTU but I think we should just leave "ResearcherID" in. More contributions can be made in the future. 😄
There was a problem hiding this comment.
I believe this pull request closes #3169 so the description should probably be change to that (instead of "related")
I just made this change.
There was a problem hiding this comment.
It would be nice to add a file under "doc/release-notes" to explain to installations what they should do to add the new values. My understanding is that they should re-run the curl command for the citation.tsv file.
@kcondon I just moved this pull request to QA without the release note mentioned above. If you want me to hop on @mderuijter 's branch and add it (or add it after merging) please let me know.
|
I just thought I'd mention that thanks to out new "spin up pull requests on EC2" automation (thank you, @donsizemore !) we can see the new author identifiers like in the screenshot below at http://ec2-3-90-251-34.compute-1.amazonaws.com
|
|
Tested, looks ok to merge. @pdurbin maybe we can just update Danny's pr with the instructions? |
Sure, I just added ee10648. Please take a look, edit etc. |
|
@pdurbin looks good, thanks |
5 participants
Related Issues
Pull Request Checklist