Skip to content

Fixed #1375 Author Identifier Additions #6358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kcondon merged 1 commit into from
Nov 12, 2019
Merged

Fixed #1375 Author Identifier Additions #6358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion scripts/api/data/metadatablocks/citation.tsv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,10 @@
authorIdentifierScheme LCNA 2
authorIdentifierScheme VIAF 3
authorIdentifierScheme GND 4
language Abkhaz 0
authorIdentifierScheme DAI 5
authorIdentifierScheme ResearcherID 6
authorIdentifierScheme ScopusID 7
language Abkhaz 0
Copy link
Member

@pdurbin pdurbin Nov 12, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got curious about why the line for "Abkhaz" changed and it looks like the trailing tabs were removed:

Screen Shot 2019-11-12 at 6 45 13 AM

It looks like the new lines for authorIdentifierScheme don't have trailing tabs either. I assume this is fine.

It would be nice to add a file under "doc/release-notes" to explain to installations what they should do to add the new values. My understanding is that they should re-run the curl command for the citation.tsv file. This process of writing release notes is described at http://guides.dataverse.org/en/4.17/developers/making-releases.html#write-release-notes

Finally, I believe this pull request closes #3169 so the description should probably be change to that (instead of "related"). On his way out the door, @djbrooke indicated that he might want to let @Venki18 make the change himself during Danny's visit to NTU but I think we should just leave "ResearcherID" in. More contributions can be made in the future. 😄

Copy link
Member

@pdurbin pdurbin Nov 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this pull request closes #3169 so the description should probably be change to that (instead of "related")

I just made this change.

Copy link
Member

@pdurbin pdurbin Nov 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to add a file under "doc/release-notes" to explain to installations what they should do to add the new values. My understanding is that they should re-run the curl command for the citation.tsv file.

@kcondon I just moved this pull request to QA without the release note mentioned above. If you want me to hop on @mderuijter 's branch and add it (or add it after merging) please let me know.

language Afar 1
language Afrikaans 2
language Akan 3
Expand Down