Skip to content

Comments

6432 - add release note about basic OIDC support#6442

Merged
kcondon merged 1 commit intoIQSS:developfrom
poikilotherm:6432-oidc-rel-note
Dec 9, 2019
Merged

6432 - add release note about basic OIDC support#6442
kcondon merged 1 commit intoIQSS:developfrom
poikilotherm:6432-oidc-rel-note

Conversation

@poikilotherm
Copy link
Contributor

What this PR does / why we need it:
This is an addendum to #6433 as requested by @pdurbin . Adding a release note as described at http://guides.dataverse.org/en/latest/developers/making-releases.html#write-release-notes

Which issue(s) this PR closes relates:

Relates to #6432

Special notes for your reviewer:
Please change or use at your own discretion @djbrooke

Suggestions on how to test this:
Not applicable.

Does this PR introduce a user interface change?:
No it doesn't.

Is there a release notes update needed for this change?:
This is a release note update. 😉

Additional documentation:
n/a

@poikilotherm poikilotherm requested a review from pdurbin December 9, 2019 14:32
@coveralls
Copy link

Coverage Status

Coverage remained the same at 19.541% when pulling 4779395 on poikilotherm:6432-oidc-rel-note into 4f1bfea on IQSS:develop.

Comment on lines +6 to +9
While with our OAuth 2.0 login options you had to implement support for every provider
by pull request, OpenID Connect provides a standardized way for authentication, user
details and more. You are able to use any provider just by loading a configuration file,
without touching the codebase.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that #4334 could be addressed without a pull request? Previously pull request #4341 was made to add support for a country-specific OAuth provider but it was closed as "we want this to be a plugin outside the core code". My understanding is that @philippconzett and @oodu run a fork of Dataverse because they need support for their country-specific login. It would be great if they could stop running a fork and get the auth support they need with configuration!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks like Obi has commented on the issue and can repopen if needed.

@pdurbin pdurbin requested a review from djbrooke December 9, 2019 16:08
@djbrooke djbrooke self-assigned this Dec 9, 2019
Copy link
Contributor

@djbrooke djbrooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @poikilotherm for the addition here. I may reword when I work on the release notes for 4.19, but it's fine to merge this. Thanks again!

Comment on lines +6 to +9
While with our OAuth 2.0 login options you had to implement support for every provider
by pull request, OpenID Connect provides a standardized way for authentication, user
details and more. You are able to use any provider just by loading a configuration file,
without touching the codebase.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks like Obi has commented on the issue and can repopen if needed.

@djbrooke djbrooke removed their assignment Dec 9, 2019
@kcondon kcondon self-assigned this Dec 9, 2019
@kcondon kcondon merged commit 81d02b1 into IQSS:develop Dec 9, 2019
@djbrooke djbrooke added this to the 4.19 milestone Dec 9, 2019
@poikilotherm poikilotherm deleted the 6432-oidc-rel-note branch April 3, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants