-
Notifications
You must be signed in to change notification settings - Fork 535
6432 - add release note about basic OIDC support #6442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # Basic OpenID Connect support | ||
| Working on epic #5974 brought us refactored code for our OAuth 2.0 based login options. | ||
| This has now been extended to provide basic support for any OpenID Connect compliant | ||
| authentication provider. | ||
|
|
||
| While with our OAuth 2.0 login options you had to implement support for every provider | ||
| by pull request, OpenID Connect provides a standardized way for authentication, user | ||
| details and more. You are able to use any provider just by loading a configuration file, | ||
| without touching the codebase. | ||
|
|
||
| While the usual prominent providers like Google et al feature OIDC support, there are | ||
| plenty of options to easily attach your current user storage to a custom made provider, | ||
| using enterprise grade software. See documentation for more details. | ||
|
|
||
| This is to be extended with support for attribute mapping, group syncing and more in | ||
| future versions of the code. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean that #4334 could be addressed without a pull request? Previously pull request #4341 was made to add support for a country-specific OAuth provider but it was closed as "we want this to be a plugin outside the core code". My understanding is that @philippconzett and @oodu run a fork of Dataverse because they need support for their country-specific login. It would be great if they could stop running a fork and get the auth support they need with configuration!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this will be the case.
https://docs.feide.no/service_providers/integration_guide/oauth_oidc/openidconnect.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks like Obi has commented on the issue and can repopen if needed.