6230 changes for upcoming glassfish upgrade#6523
Merged
Conversation
…t properties of objects (that could fail bean validation)
#6504 fix lock refresh
revert formatting changes in branch
…ial submits (ownerId is currently used by functionality, other than just as a viewParam)
scolapasta
changed the title
pdurbin
approved these changes
Jan 15, 2020
Member
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
I've been watching the commits as they come in and they all look fine to me. Approved. Moving to QA. The only slight surprise is that this pull request aims to fix #6472 so that issue should definitely be tested. This was already mentioned in the testing guidance in the description of this pull request.
Contributor
|
This looks ok to merge, all functionality appears working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
These PR makes changes that allow the app to run with JSF 2.3 (specifically 2.3.14) and will allow us to upgrade our app server.
Which issue(s) this PR closes:
It is in progress for #6230, but we are also still looking for other issues.
It does close #6472 as I fixed it here before realizing it happens in current prod (and opened up this issue)
Special notes for your reviewer:
there are 3 fundamental changes:
• don't store ids (and alias for dataverse) from the viewParam in as the id (or alias) of an object, but have dedicated fields on the backing bean
• for viewparams that refer to fields that can change and used after partial submits, switch to omnifaces view params
• for converters don't use
@injector@ejbannotationSuggestions on how to test this:
An overall smoke test could be good, but some specific things based on the changes:
• Initial load of dataverse and dataset page
• edit dataset button works
• converters, so basically things like role permissions autocomplete, facet selection, metadata selection
Note: the purpose of this PR is not to fix anything specifically, but to not introduce new bugs when deploying to a later app server; so, while if you find a bug, please verify if that bug already exists in the current code base.
Does this PR introduce a user interface change?:
No.
Is there a release notes update needed for this change?:
No. Though eventually there will be, when we upgrade app server, the purpose of this PR is to proactively get these changes in, but still run on glassfish 4.1.
Additional documentation: