Skip to content

6545 solr var meta#6577

Merged
kcondon merged 12 commits intoIQSS:developfrom
lubitchv:6545-solr-var-meta
Jan 28, 2020
Merged

6545 solr var meta#6577
kcondon merged 12 commits intoIQSS:developfrom
lubitchv:6545-solr-var-meta

Conversation

@lubitchv
Copy link
Contributor

Variable level metadata that is updated using DCT (variable label, literal question, interview instructions, post question, universe) will be searchable with solr. Also small bugs connected to datasetVerionId and DRAFT version with solr and FilePage were fixed.

Closes #6545

@coveralls
Copy link

coveralls commented Jan 24, 2020

Coverage Status

Coverage decreased (-0.01%) to 19.481% when pulling b66d6dc on lubitchv:6545-solr-var-meta into 80c3bbe on IQSS:develop.

@djbrooke
Copy link
Contributor

Hey @lubitchv - we'll review this soon. I'm planning to add some more detailed tooltips. Can you give me write access to your branch?

@djbrooke
Copy link
Contributor

@lubitchv nevermind, I already have access. Sorry about the false alarm! Commit incoming...

@djbrooke
Copy link
Contributor

@lubitchv I added tooltips based on DDI 2.5 here:

https://ddialliance.org/explore-documentation

Copy link
Contributor

@sekmiller sekmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In solrSearchResult getFileDatasetUrl() I'm not sure you always want to return result=DRAFT when there's a draft version. It would force guest users to the login screen and might cause users without permission to get an unauthorized access error.

@lubitchv
Copy link
Contributor Author

@sekmiller But guest user would not get a draft file listed in the search anyway, so he will not be able to get this link anyway. But maybe you have a specific scenario in mind that I am missing.

Although for non guest user who will get listing of a draft file, after pressing the dataset link provided, he will end up with published version and not draft and this is confusing.

@kcondon kcondon self-assigned this Jan 28, 2020
@kcondon
Copy link
Contributor

kcondon commented Jan 28, 2020

@lubitchv Hi, so I plan to test this by doing the following. Please let me know if I am missing anything. Also, please add a release note indicating a need to change shema.xml and whether or not a full reindex is needed.
To test:

  1. Using DCT tool, modify above mentioned fields and verify they are searchable.
  2. Create multiple dataset versions and modify file history too, confirm changes are visible in dataset and file version history.
  3. Confirm a draft file url is not accessible by guest and is accessible if you have permission.
  4. Determine steps to enable this feature: ie. new schema.xml, restart solr, reindex?

@kcondon
Copy link
Contributor

kcondon commented Jan 28, 2020

@lubitchv Thanks for the release note!

@lubitchv
Copy link
Contributor Author

@kcondon The plan looks good!

@kcondon kcondon merged commit 86b53fa into IQSS:develop Jan 28, 2020
@djbrooke djbrooke added this to the 4.20 milestone Feb 7, 2020
@djbrooke
Copy link
Contributor

@lubitchv, we unfortunately had to revert the changes related to indexing as it slowed indexing down to the point where it would no longer complete. This reversion was done in #6704 and @sekmiller should be able to provide more information if needed. We'd still like to get this to Dataverse, but it was a blocker for the 4.20 release, so we pulled it out for now.

I'll plan to reopen #6545 and if there's anything you need from us please let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Solr search and variable level metadata

6 participants