Conversation
|
Hey @lubitchv - we'll review this soon. I'm planning to add some more detailed tooltips. Can you give me write access to your branch? |
|
@lubitchv nevermind, I already have access. Sorry about the false alarm! Commit incoming... |
|
@lubitchv I added tooltips based on DDI 2.5 here: |
sekmiller
left a comment
There was a problem hiding this comment.
In solrSearchResult getFileDatasetUrl() I'm not sure you always want to return result=DRAFT when there's a draft version. It would force guest users to the login screen and might cause users without permission to get an unauthorized access error.
|
@sekmiller But guest user would not get a draft file listed in the search anyway, so he will not be able to get this link anyway. But maybe you have a specific scenario in mind that I am missing. Although for non guest user who will get listing of a draft file, after pressing the dataset link provided, he will end up with published version and not draft and this is confusing. |
|
@lubitchv Hi, so I plan to test this by doing the following. Please let me know if I am missing anything. Also, please add a release note indicating a need to change shema.xml and whether or not a full reindex is needed.
|
…verse into 6545-solr-var-meta
|
@lubitchv Thanks for the release note! |
|
@kcondon The plan looks good! |
|
@lubitchv, we unfortunately had to revert the changes related to indexing as it slowed indexing down to the point where it would no longer complete. This reversion was done in #6704 and @sekmiller should be able to provide more information if needed. We'd still like to get this to Dataverse, but it was a blocker for the 4.20 release, so we pulled it out for now. I'll plan to reopen #6545 and if there's anything you need from us please let us know. |
Variable level metadata that is updated using DCT (variable label, literal question, interview instructions, post question, universe) will be searchable with solr. Also small bugs connected to datasetVerionId and DRAFT version with solr and FilePage were fixed.
Closes #6545