Conversation
pdurbin
approved these changes
Feb 27, 2020
Contributor
|
@sekmiller It looks like batch index performance became a lot slower: from 18hours to 6days, estimated. Will do further testing to see whether it is a completion rate issue versus a memory/resource problem, versus a few problem datasets. Update: Ran it again , starting at 2pm on 3/3. It is still running but only 26k of 95k datasets indexed and appears to be 4 mins between indexing a dataset. CPU ~98%, mem ok, 30% used, ~3500 open file descriptors. This increasingly slow to index behavior feels like an algorithm issue where it is reprocessing an entire list that gets slower as list gets larger. We've seen it in other batch jobs in the past. Just speculation though. |
This was referenced Mar 13, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This makes the indexing of linked dataverses more efficient by modifying the solr docs of the owned datasets instead of doing a full re-index. When the datasets were fully re-indexed dataverses with large numbers of datasets would fail to re-index.
Which issue(s) this PR closes:
Closes #6665
Special notes for your reviewer:
Suggestions on how to test this:
verify that a dataverse with a large number of datasets (mra - for one) can be re-indexed via the api. Also verify that linking dataverses also display the datasets of the linked dataverse.
Does this PR introduce a user interface change?:
no
Is there a release notes update needed for this change?:
none
Additional documentation: