Conversation
sekmiller
approved these changes
Feb 21, 2020
Contributor
sekmiller
left a comment
sekmiller
left a comment
There was a problem hiding this comment.
I put my comment on the wrong PR. Looks good but I don't have anything locally to get extensive results from the queries.
Contributor
|
Thanks @sekmiller for the review. I have some small text changes that I'll discuss with @landreev and then we can send this out. I'll assign to myself for now and Leonid and I can talk after standup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
No application code in this PR. Only documentation and a diagnostic tool to be sent out to the remote installations, to check if their databases have been affected by these issues.
The release note in this PR supercedes the release note added in #6612 (removed in this PR).
Same for the "pre-release note" - we are only sending out ONE note/one diagnostics script to the remote installations; which checks for both this issue, #6510 and #6525
Which issue(s) this PR closes:
Closes #6510
Special notes for your reviewer:
Suggestions on how to test this:
testing the diagnostic script against the copy of the prod. db on vm5 should confirm that neither issue is present; since our database has already been cleaned up.
If we have an older (2+ months) snapshot sitting around, a more thorough test could be to run it against that, to confirm that it actually finds the issues, when present.
Does this PR introduce a user interface change?:
Is there a release notes update needed for this change?:
Additional documentation: