Skip to content

7011 - Render logic for signup link on login page#7012

Merged
kcondon merged 1 commit intoIQSS:developfrom
poikilotherm:7011-render-signup
Jul 2, 2020
Merged

7011 - Render logic for signup link on login page#7012
kcondon merged 1 commit intoIQSS:developfrom
poikilotherm:7011-render-signup

Conversation

@poikilotherm
Copy link
Contributor

@poikilotherm poikilotherm commented Jun 24, 2020

What this PR does / why we need it:

Users should not get confused about a non-existing, error 401 prone signup link on the login page.

Which issue(s) this PR closes:

Closes #7011

Special notes for your reviewer:
The underlying function has been used in various other places (e. g. the header UI, hidding the very same link there), so this is really straight forward.

Suggestions on how to test this:

  1. Deploy
  2. Disable signup
  3. Goto Login page and check if link is not rendered anymore.
  4. Enable signup
  5. Goto Login page and check if link is rendered again.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Yes. Please see the opening of #6170, where the initial link has been mocked. This is simply hidden again when signup is disabled.

Is there a release notes update needed for this change?:
I don't think so. It's a small fix.

Additional documentation:
Nada.

@poikilotherm poikilotherm requested a review from mheppler June 24, 2020 13:03
@coveralls
Copy link

Coverage Status

Coverage remained the same at 19.557% when pulling 6575273 on poikilotherm:7011-render-signup into b97185a on IQSS:develop.

Copy link
Contributor

@mheppler mheppler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good. The render logic used for sign up link in the navbar is being applied here.

@kcondon kcondon self-assigned this Jul 2, 2020
@kcondon kcondon merged commit e20c094 into IQSS:develop Jul 2, 2020
@djbrooke djbrooke added this to the Dataverse 5 milestone Jul 6, 2020
@poikilotherm poikilotherm deleted the 7011-render-signup branch August 10, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

As a user I don't want to be confused by a non-working signup link if signup is disabled

5 participants