#6972 allow pdf download if "original" is selected.#7597
Merged
Conversation
scolapasta
reviewed
Feb 10, 2021
Contributor
scolapasta
left a comment
scolapasta
left a comment
There was a problem hiding this comment.
This looks reasonable enough as a quick fix, but I'll ask @landreev to also give it a quick lookover, as he had commented on the issue.
landreev
approved these changes
Feb 11, 2021
Contributor
landreev
left a comment
landreev
left a comment
There was a problem hiding this comment.
Approving the PR.
My only suggestion would be to maybe add one sentence under "how to test", and clarify, that the choice of "tabular" vs. "original" will still be showing in the pulldown. But the download will actually work for a single non-tab. file with the fix in place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If a user selects "original" file format as the download option for a non-tabular file it fails.
Which issue(s) this PR closes:
Closes #6972
Special notes for your reviewer:
Applies a test of whether a file selected to be downloaded as "original" is tabular. Similar to how it is handled for a multiple file download.
Suggestions on how to test this:
If there are tabular files present in a dataset the option for downloading any file as "original" will be present. The user should be able to select a single non-tabular file and successfully download it by selecting "original".
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
no
Is there a release notes update needed for this change?:
no
Additional documentation:
none