Conversation
scolapasta
reviewed
Jun 8, 2021
| List<Dataverse> linkingDataverses = findAllLinkingDataverses(dvo); | ||
| List<String> linkingDataversePaths = findLinkingDataversePaths(linkingDataverses); | ||
| for (String dvPath : linkingDataversePaths) { | ||
| dataversePaths.add(dvPath); |
Contributor
There was a problem hiding this comment.
can this be simplfied? since findLinkingDataversePaths reutns a List just add that directly to dataversePaths (with addAll) instead of looping through?
scolapasta
approved these changes
Jun 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Fixes the indexing of datasets and dataverses to dataverses that are more than one generation removed from Root DV
Which issue(s) this PR closes:
Closes #7766 Linking a dataverse into a "grandchild" of Root not working
Special notes for your reviewer: also removes extraneous paths not needed for display. see original ticket for more info.
Suggestions on how to test this: verify that linking to dataverses more than one level down from Root DV works/(shows linked datasets and dataverses in the linking DV) Also that re-index all and re-index individual DV retains links to linked dataverses.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: