remove NONE as a license option for SWORD, show available licenses #8551#8558
Merged
remove NONE as a license option for SWORD, show available licenses #8551#8558
Conversation
qqmyers
reviewed
Mar 30, 2022
src/main/java/edu/harvard/iq/dataverse/api/datadeposit/SwordServiceBean.java
Show resolved
Hide resolved
qqmyers
reviewed
Mar 30, 2022
qqmyers
requested changes
Mar 30, 2022
Member
There was a problem hiding this comment.
Looks OK - I didn't run it.
If I understand, the only main code change is to add the list of active licenses in the response.
My comment there suggests adding a check to make sure the request License is active, which would be a minor functionality change.
The other changes fix the example, add good tests, update docs. I saw one more CC0 that could be changed but it all makes sense.
qqmyers
approved these changes
Mar 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The example XML in the SWORD docs doesn't work due to licenses changes in 5.10 and PR #7920.
Which issue(s) this PR closes:
Special notes for your reviewer:
I added some minimal testing of interactions between license and rights. We could add more.
I'm not 100% sure of all the assertions in the SWORD page of the API Guide. We could add more tests and/or edit the guide as needed.
Generally speaking, I'm thinking we should drop NONE as an option, even if it's an incompatible change. If we want to keep NONE, what should it map to? Custom Dataset Terms? But they can't be blank, right?
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
Maybe?
Additional documentation:
None.