Merged
Conversation
scolapasta
approved these changes
Apr 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This should be a fix for the problem of the footer appearing mid-page when a custom footer is used. It should maintain the previous spacing other page content.
Which issue(s) this PR closes:
Closes #8587
Special notes for your reviewer: FWIW: The main issue is that position:absolute on the footer element appears to work with no custom footer but causes problems when a custom footer exists. To maintain spacing when the footer is not absolute, a padding-top on the #dvfooter element is needed. The other deletions in the code either have no effect or (for footer:height just remove blank space at the bottom of the page.)
Suggestions on how to test this: Should look at positioning of footer in both default and with custom-footer cases on multiple pages (e.g. the main dataverse/dataset list page and the login page.)
Does this PR introduce a user interface change? If mockups are available, please link/include them here: only fixes a regression
Is there a release notes update needed for this change?:
Additional documentation: