Change description of admin role #3189

[konradperlowski]

What this PR does / why we need it:

changes admin role description - specifying that admin role can approve request to restricted data

Which issue(s) this PR closes:

• Closes Permissions: update "roles" description for "Admins" to specify this role allows you to approve requests to restricted data #3189

Special notes for your reviewer: None

Suggestions on how to test this:

Check if description is valid

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

In the permissions section, description of admin role was changed:

Is there a release notes update needed for this change?: No

Additional documentation: None

[TaniaSchlatter]

Looks good!

[pdurbin]

In Slack both @sbarbosadataverse and @TaniaSchlatter approved the wording change: https://iqss.slack.com/archives/CVB2SMDFX/p1651231790124739

I'll go ahead and approve this.

@konradperlowski please don't worry about the "docs/readthedocs.org:dataverse-guide" check failing. This is new and should stop failing once we merge PR #8651.

For other developers I'd like to point out that we're storing the description of roles in two places (now that PR #5158 has been merged), which seems a bit suboptimal to me.

Changing src/main/java/propertyFiles/BuiltInRoles.properties as this pull request does is the right thing to do. The old description is in the database...

dvndb=> select name,description from dataverserole where name = 'Admin';
 name  |                              description                              
-------+-----------------------------------------------------------------------
 Admin | A person who has all permissions for dataverses, datasets, and files.
(1 row)

... but it's in English and seems to be treated in the code as a fallback:

public String getDescription() {
    if (alias != null) {
        String key = "role." + alias.toLowerCase() + ".description";
        try {
            String _description = BundleUtil.getStringFromPropertyFile(key, "BuiltInRoles");
            if (_description == null) {
                return description;
            } else {
                return _description;
            }

I doubt the database version is used very often. And it would be a bad experience for non-English installations. At some point we should probably drop the description field from the dataverserole table. (And blank out the description string from scripts/api/data/role-admin.json.) For now, I think we should simply allow BuiltInRoles.properties to be the source of truth and not worry about what's in the database.