Iqss/8757 file restriction with public install#8758
Conversation
Version 5.10
|
@haarli hi, can you please merge the latest from "develop" into your branch? (I can't, I got We're investigating trouble with our Jenkins server and this is an easy way to trigger a run. Also, it should fix the readthedocs check that's failing. Thanks! |
|
Sure. Latest develop is merged now |
qqmyers
left a comment
There was a problem hiding this comment.
Looks good. FWIW: I'm working in the same area for Harvard Data Commons and have tested these changes there.
|
FWIW: an update: A more extensive change in this area is coming soon (PR by June 30) from the Harvard Data Commons Objective 1 work - adding code there to stop both restriction and embargo when data is public and redefining public as when the :PublicInstallation setting is set or when a dataset is using a store that is identified as public (a new jvm option for stores) - the latter allowing use of some stores (like public remote stores or globus accessible S3 buckets) where Dataverse cannot enforce access control (or restrictions or embargo) without requiring the whole instance to be public. |
|
Hi @haarli I'm ready to test this but would you please refresh from develop? We've released a new version and have incremented the version numbers. Regards, Kevin |
What this PR does / why we need it:
This PR deactivates the possibility to restrict files when the setting ":PublicInstall" is set to true, as it should be according to the guide.
Which issue(s) this PR closes:
Closes #8757