Skip to content

Iqss/8757 file restriction with public install#8758

Merged
kcondon merged 8 commits intoIQSS:developfrom
MPDL:IQSS/8757_file_restriction_with_publicInstall
Jun 23, 2022
Merged

Iqss/8757 file restriction with public install#8758
kcondon merged 8 commits intoIQSS:developfrom
MPDL:IQSS/8757_file_restriction_with_publicInstall

Conversation

@haarli
Copy link
Contributor

@haarli haarli commented Jun 1, 2022

What this PR does / why we need it:
This PR deactivates the possibility to restrict files when the setting ":PublicInstall" is set to true, as it should be according to the guide.

Which issue(s) this PR closes:
Closes #8757

@pdurbin
Copy link
Member

pdurbin commented Jun 1, 2022

@haarli hi, can you please merge the latest from "develop" into your branch?

(I can't, I got ERROR: Permission to MPDL/dataverse.git denied to pdurbin)

We're investigating trouble with our Jenkins server and this is an easy way to trigger a run. Also, it should fix the readthedocs check that's failing.

Thanks!

@haarli
Copy link
Contributor Author

haarli commented Jun 2, 2022

Sure. Latest develop is merged now

Copy link
Member

@qqmyers qqmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. FWIW: I'm working in the same area for Harvard Data Commons and have tested these changes there.

@qqmyers
Copy link
Member

qqmyers commented Jun 23, 2022

FWIW: an update: A more extensive change in this area is coming soon (PR by June 30) from the Harvard Data Commons Objective 1 work - adding code there to stop both restriction and embargo when data is public and redefining public as when the :PublicInstallation setting is set or when a dataset is using a store that is identified as public (a new jvm option for stores) - the latter allowing use of some stores (like public remote stores or globus accessible S3 buckets) where Dataverse cannot enforce access control (or restrictions or embargo) without requiring the whole instance to be public.

@kcondon
Copy link
Contributor

kcondon commented Jun 23, 2022

Hi @haarli I'm ready to test this but would you please refresh from develop? We've released a new version and have incremented the version numbers. Regards, Kevin

@kcondon kcondon self-assigned this Jun 23, 2022
@kcondon kcondon merged commit b88f0df into IQSS:develop Jun 23, 2022
@pdurbin pdurbin added this to the 5.12 milestone Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: File restriction still possible with setting PublicInstall

4 participants