Skip to content

class field can be replaced by local variable #8809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pdurbin merged 1 commit into from
Sep 8, 2022
Merged

class field can be replaced by local variable #8809

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/main/java/edu/harvard/iq/dataverse/api/datadeposit/SWORDv2ContainerServlet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ public class SWORDv2ContainerServlet extends SwordServlet {
ContainerManagerImpl containerManagerImpl;
@Inject
StatementManagerImpl statementManagerImpl;
private ContainerManager cm;
// private ContainerManager cm; this field can be replaced by local variable
private ContainerAPI api;
private StatementManager sm;
// private StatementManager sm; this field can be replaced by local variable
private final ReentrantLock lock = new ReentrantLock();


Expand All @@ -28,13 +28,16 @@ public void init() throws ServletException {
super.init();

// load the container manager implementation
this.cm = containerManagerImpl;
// this.cm = containerManagerImpl;
ContainerManager cm = containerManagerImpl;

// load the statement manager implementation
this.sm = statementManagerImpl;
// this.sm = statementManagerImpl;
StatementManager sm = statementManagerImpl;

// initialise the underlying servlet processor
this.api = new ContainerAPI(this.cm, this.sm, this.config);
// this.api = new ContainerAPI(this.cm, this.sm, this.config);
this.api = new ContainerAPI(cm, sm, this.config);
}

@Override
Expand Down