class field can be replaced by local variable#8809
Conversation
|
Hi @noobyu6 , for this next sprint we are catching up on Community PRs. Would you mind updating/ refreshing thiis PR from develop? Thanks! |
pdurbin
left a comment
There was a problem hiding this comment.
All the SWORD tests are passing: https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-8809/1/testReport/edu.harvard.iq.dataverse.api/SwordIT/
I'm approving this. Off to QA. Thanks, @noobyu6!
|
As discussed at standup, we're comfortable with the same person doing review and QA. I'm merging this. Again, it's a trivial change and the SWORD API tests pass. |
|
@noobyu6 I'm very sorry but I merged this pull request without noticing that it was targeting the "master" branch rather than the "develop" branch. Can you please create a new pull request that targets the "develop" branch? Thanks. |
|
I see the same situation exists in the master branch, so merging into the master branch is also ok |
What this PR does / why we need it:
class fields can be replaced by local variables which can save memory
Which issue(s) this PR closes:
Special notes for your reviewer:
no
Suggestions on how to test this:
code review
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
no
Is there a release notes update needed for this change?:
reduce memory usage
Additional documentation: