Skip to content

Comments

class field can be replaced by local variable#8970

Merged
kcondon merged 2 commits intoIQSS:developfrom
noobyu6:develop
Feb 16, 2023
Merged

class field can be replaced by local variable#8970
kcondon merged 2 commits intoIQSS:developfrom
noobyu6:develop

Conversation

@noobyu6
Copy link
Contributor

@noobyu6 noobyu6 commented Sep 9, 2022

What this PR does / why we need it:

class fields can be replaced by local variables which can save memory

Which issue(s) this PR closes:

Special notes for your reviewer:

no

Suggestions on how to test this:

code review

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

no

Is there a release notes update needed for this change?:

reduce memory usage

Additional documentation:

@coveralls
Copy link

coveralls commented Sep 9, 2022

Coverage Status

Coverage: 20.009%. Remained the same when pulling 80ad3db on noobyu6:develop into 1aabf69 on IQSS:develop.

@mreekie mreekie added the bk2211 label Nov 1, 2022
@pdurbin pdurbin added Type: Suggestion an idea Component: Code Infrastructure formerly "Feature: Code Infrastructure" User Role: Hackathon Participant Core developers, frequent contributors, drive-by contributors, etc. Size: 3 A percentage of a sprint. 2.1 hours. labels Dec 15, 2022
@mreekie
Copy link

mreekie commented Jan 10, 2023

Prio meeting with Stefano.

  • Moved from Community Backlog to ordered backlog

@mreekie mreekie removed the bk2211 label Jan 11, 2023
@pdurbin
Copy link
Member

pdurbin commented Feb 14, 2023

@noobyu6 thanks for the pull request. Next time, please create a branch called something other than "develop".

I just merged the latest from origin/develop into noobyu6/develop but it's weird. Here are my notes:

# do all this in /tmp away from your normal code
cd /tmp
git clone git@github.com:IQSS/dataverse.git
cd dataverse
git remote add noobyu6 git@github.com:noobyu6/dataverse.git
git fetch noobyu6
# make a new branch not called develop (dev2)
git co noobyu6/develop -b dev2
git merge origin/develop
# delete the real develop branch (!) locally
git branch -d develop
# checkout dev2 (false develop)  as develop for now
git co -b develop
# push the false develop to the contributor's fork (to the PR)
git push noobyu6 develop 
cd ..
# delete the tmp space
rm -rf /tmp/dataverse

Anyway, I'm just waiting for the tests to pass. Then I'll move this to QA. Thanks again.

@pdurbin pdurbin self-assigned this Feb 14, 2023
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing. Approved!

@pdurbin pdurbin removed their assignment Feb 15, 2023
@kcondon kcondon self-assigned this Feb 16, 2023
@kcondon kcondon merged commit b190a0c into IQSS:develop Feb 16, 2023
@pdurbin pdurbin added this to the 5.14 milestone Feb 16, 2023
@cmbz cmbz added the FY26 Sprint 4 FY26 Sprint 4 (2025-08-13 - 2025-08-27) label Aug 16, 2025
@cmbz cmbz added FY26 Sprint 14 FY26 Sprint 14 (2025-12-31 - 2026-01-14) and removed FY26 Sprint 14 FY26 Sprint 14 (2025-12-31 - 2026-01-14) labels Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Code Infrastructure formerly "Feature: Code Infrastructure" FY26 Sprint 4 FY26 Sprint 4 (2025-08-13 - 2025-08-27) Size: 3 A percentage of a sprint. 2.1 hours. Type: Suggestion an idea User Role: Hackathon Participant Core developers, frequent contributors, drive-by contributors, etc.

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Feature Request/Idea:Code optimization suggestions

6 participants