Skip to content

class field can be replaced by local variable #8970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kcondon merged 2 commits into from
Feb 16, 2023
Merged

class field can be replaced by local variable #8970

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82c9ec8
modify class field to local variable
noobyu6 Sep 9, 2022
80ad3db
Merge branch 'origin/develop' into 'noobyu6/develop' #8771
pdurbin Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions src/main/java/edu/harvard/iq/dataverse/api/datadeposit/SWORDv2ContainerServlet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,11 @@ public class SWORDv2ContainerServlet extends SwordServlet {
ContainerManagerImpl containerManagerImpl;
@Inject
StatementManagerImpl statementManagerImpl;
private ContainerManager cm;
// this field can be replaced by local variable
// private ContainerManager cm;
private ContainerAPI api;
private StatementManager sm;
// this field can be replaced by local variable
// private StatementManager sm;
private final ReentrantLock lock = new ReentrantLock();


Expand All @@ -28,13 +30,15 @@ public void init() throws ServletException {
super.init();

// load the container manager implementation
this.cm = containerManagerImpl;

// load the statement manager implementation
this.sm = statementManagerImpl;
// this.cm = containerManagerImpl;
ContainerManager cm = containerManagerImpl;
// load the statement manager implementation
// this.sm = statementManagerImpl;
StatementManager sm = statementManagerImpl;

// initialise the underlying servlet processor
this.api = new ContainerAPI(this.cm, this.sm, this.config);
// this.api = new ContainerAPI(this.cm, this.sm, this.config);
this.api = new ContainerAPI(cm, sm, this.config);
}

@Override
Expand Down