Skip to content

Comments

update link in harvestserver.rst#9436

Closed
Rehan-stack wants to merge 1 commit intoIQSS:developfrom
Rehan-stack:develop
Closed

update link in harvestserver.rst#9436
Rehan-stack wants to merge 1 commit intoIQSS:developfrom
Rehan-stack:develop

Conversation

@Rehan-stack
Copy link
Contributor

@Rehan-stack Rehan-stack commented Mar 12, 2023

@pdurbin
Copy link
Member

pdurbin commented Mar 12, 2023

I checked the link at https://dataverse-guide--9436.org.readthedocs.build/en/9436/admin/harvestserver.html and it looks perfect! Thanks, @Rehan-stack!

I'm going to add the magic "closes" syntax to the description above so that it closes the issue in question.

@pdurbin pdurbin self-assigned this Mar 12, 2023
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rehan-stack perfect! Thank you! Sending to QA to merge.

@pdurbin
Copy link
Member

pdurbin commented Mar 12, 2023

@Rehan-stack out of curiosity, did you use the "quick fix" workflow at https://guides.dataverse.org/en/latest/developers/documentation.html#quick-fix ?

I'm asking because when I follow that workflow, the branch in my fork is called "patch-1" (or patch-2, etc.). But in your fork the branch is called "develop". This is not a problem for this tiny fix (but it sometimes can be a problem for us). Just curious! 😄

@Rehan-stack
Copy link
Contributor Author

@Rehan-stack out of curiosity, did you use the "quick fix" workflow at https://guides.dataverse.org/en/latest/developers/documentation.html#quick-fix ?

I'm asking because when I follow that workflow, the branch in my fork is called "patch-1" (or patch-2, etc.). But in your fork the branch is called "develop". This is not a problem for this tiny fix (but it sometimes can be a problem for us). Just curious! 😄

No i do not follow that.

@pdurbin
Copy link
Member

pdurbin commented Mar 12, 2023

No i do not follow that.

@Rehan-stack ok, no problem. Are you interested in making future contributions? (You seem to like Python and I can point you at some projects!) If so, please create a branch other than "develop" when making your pull request next time. For example, something like 9168-fix-link would be a nice name. We explain this here: https://guides.dataverse.org/en/5.13/developers/version-control.html#create-a-new-branch-off-the-develop-branch

@Rehan-stack
Copy link
Contributor Author

ok that will be great to work in python. I will make another PR with new branch on this issue.

@pdurbin
Copy link
Member

pdurbin commented Mar 13, 2023

Great! Please jump in https://chat.dataverse.org to talk about Python sometime. Maybe you can help with https://github.com/gdcc/pyDataverse

Thanks for the new PR. I'm closing this one in favor of that one:

@pdurbin pdurbin closed this Mar 13, 2023
@pdurbin pdurbin removed their assignment Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spreadsheet of DV Installations referred to in OAI doc is deprecated

2 participants