Closed
Conversation
impements POST-redirect-GET for DP Creator tool POST is currently done on server, gets a redirect response, and GETs the new location in the browser Need to change the way the base context is gotten for POST, as in the GET code, it always uses the extenal tool url as provided in the configuration - the redirect use be a different context than the configured tool url.
remove some experimental code
…/dataverse into 7715-signed-urls-for-external-tools
…ar DPCreator WIP - still need to handle use of signed Url to access resource on dataverse
…-signed-urls-for-external-tools Validation fix and API call
…-signed-urls-for-external-tools Define/use an additional secret key, Refactor token replacement for signed urls
…-signed-urls-for-external-tools 7715 signed urls for external tools
…-signed-urls-for-external-tools Minor tweaks from #7325 review
…sy and brittle, Probably still a little string building could be cleaned up
Member
|
Closing in favor of the new branch/PR: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: uses JsonObjectBuilder to create Json cleanly
Which issue(s) this PR closes:
Closes #
Special notes for your reviewer: QueryParameters code still needs some cleanup. Keeps old string-building code because the getTokenValue in UrlTokenUtil is private.
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: