8346 License internationalizataion#9125
Merged
kcondon merged 18 commits intoIQSS:developfrom Dec 7, 2022
Merged
Conversation
…alizataion # Conflicts: # src/main/java/edu/harvard/iq/dataverse/dataset/DatasetUtil.java
…icenseInternationalizataion
…olarsportal/dataverse into licenseInternationalizataion
JayanthyChengan
changed the title
qqmyers
approved these changes
Nov 3, 2022
Member
qqmyers
left a comment
qqmyers
left a comment
There was a problem hiding this comment.
Looks good. The one question I have is whether it would make sense to refactor to have a getLocalizesLicenseDetails(License, String) or (License, Enum) interface. For the former that would mean doing license.getName() once within the method instead of all the callers.
…olarsportal/dataverse into licenseInternationalizataion
Contributor
Author
|
@qqmyers - Please take a look at the changes when you have time. Thanks |
Member
|
Gave it a 10. Should be just testing with French or whatever. |
|
Added to 12/1/2022 sprint on 12/5/2022 |
pdurbin
approved these changes
Dec 7, 2022
Member
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
I didn't test this but the code and docs look fine to me. All the API tests passed. Approving.
Contributor
Author
cmbz
added
FY26 Sprint 14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR closes:
Closes #8346