extract metadata (NcML XML) from NetCDF/HDF5 files, new "requirements" option for external tools#9239
extract metadata (NcML XML) from NetCDF/HDF5 files, new "requirements" option for external tools#9239
Conversation
The use case is an external tool that operates on aux files pulled out of NetCDF/HDF5 files.
|
The failing test is this: java.lang.AssertionError: expected:<201> but was:<500> I just clicked "build now" to see if that fixes it. |
|
Update. This was reviewed by Stephen, but is on hold pending some code tweaks from Phil. |
|
update: Permissions are being discussed. |
I just added this in e2066c8. I'm ready for more review so I'm unassigning myself. |
src/main/java/edu/harvard/iq/dataverse/ingest/IngestServiceBean.java
Outdated
Show resolved
Hide resolved
|
@sekmiller and talked a bit about the new "requirements" feature for external tools. I also removed an extraneous println he caught. Finally, I merged the latest from develop in. |
sekmiller
left a comment
There was a problem hiding this comment.
Spoke with Phil to get a fuller understanding of "meetsRequirements" on the external tool. passing to qa
|
size=10 for the next sprint |
|
I'm not sure why I'm seeing this at https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-9239/8/consoleFull TASK [dataverse : fire off installer] ****************************************** |
"Use a version like '4.11.0.1' in the example above where the previously released version was 4.11" -- dev guide That is, these scripts should have been 5.12.1.whatever since the last release was 5.12.1. Fixing. (They were 5.13.whatever.)
|
Generally works good. Found 2 issues:
|
|
Since the first issue was not reproducible and the second affects an external tool, we're merging and will work on the external tool side of things separately. |
What this PR does / why we need it:
From talking to researchers who use NetCDF and HDF5 files, we believe there is value in extracting metadata from those files to give some insight about their contents.
I plan to also make a pull request in the https://github.com/gdcc/dataverse-previewers repo to add a preview tool for the extracted file, which is in NcML format.
Which issue(s) this PR closes:
Special notes for your reviewer:
Additional scope we could consider:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No but here's an example of two HDF5 files where one doesn't show the eyeball because it doesn't meet the requirement of having a aux file:
Is there a release notes update needed for this change?:
Yes, included.
Additional documentation:
Included.