Conversation
qqmyers
requested changes
Dec 20, 2022
Member
qqmyers
left a comment
qqmyers
left a comment
There was a problem hiding this comment.
Didn't run this but it follows the basic pattern of all the other ones. I left a couple requests and a question about XSS filtering.
Member
Author
|
Because I can't put this PR on https://github.com/orgs/IQSS/projects/2 I'm using the following issue to represent its state: I'm about to move it back to review since I believe I've addressed the feedback so far. While I'm here I'll leave a screenshot of the expected error page, which I was just testing:
|
qqmyers
approved these changes
Dec 22, 2022
Member
|
Looks good. The XSS filtering might be more than needed (i.e. the html previewer filters much less than the text previewer), but that can be adjusted as people play with real NetCDF files and decide what's useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a screenshot of how it looks: