Opens Payara Admin Console port in the dev containerized setup#9478
Merged
kcondon merged 2 commits intoIQSS:developfrom Mar 27, 2023
Merged
Opens Payara Admin Console port in the dev containerized setup#9478kcondon merged 2 commits intoIQSS:developfrom
kcondon merged 2 commits intoIQSS:developfrom
Conversation
pdurbin
approved these changes
Mar 27, 2023
pdurbin
requested changes
Mar 27, 2023
Member
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
Let's add some sort of reminder about security, per Don's comment.
|
|
||
| Check that you can log in to http://localhost:8080 using user ``dataverseAdmin`` and password ``admin1``. | ||
|
|
||
| You can also access the Payara Admin Console if needed, which is available at http://localhost:4848. To log in, use user ``admin`` and password ``admin``. |
Member
There was a problem hiding this comment.
Suggested change
| You can also access the Payara Admin Console if needed, which is available at http://localhost:4848. To log in, use user ``admin`` and password ``admin``. | |
| You can also access the Payara Admin Console if needed, which is available at http://localhost:4848. To log in, use user ``admin`` and password ``admin``. As a reminder, this container is only for development usage! In production (which you shouldn't use these images for), do not expose port 4848 and if you leave the admin console enabled, change the password! |
Contributor
Author
There was a problem hiding this comment.
I have rephrased the disclaimer a bit. I would rather not suggest opening the console in any case for production.
GPortas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Opens port 4848 of the dev_dataverse service, inside the docker-compose-dev file, to make the Payara Admin Console accessible in the containerized setup.
Which issue(s) this PR closes
Special notes for your reviewer
N/A
Suggestions on how to test this
adminand passwordadminDoes this PR introduce a user interface change? If mockups are available, please link/include them here
No
Is there a release notes update needed for this change?
No
Additional documentation
N/A