Skip to content

reduce logging for download file guestbook/terms bug#9863

Closed
pdurbin wants to merge 2 commits intodevelopfrom
9806-logging
Closed

reduce logging for download file guestbook/terms bug#9863
pdurbin wants to merge 2 commits intodevelopfrom
9806-logging

Conversation

@pdurbin
Copy link
Member

@pdurbin pdurbin commented Aug 30, 2023

What this PR does / why we need it:

The excessive logging will drive them mad. 😵‍💫

Which issue(s) this PR closes:

Special notes for your reviewer:

Yes, it's a bummer that we have to add the same asadmin command in two places.

Suggestions on how to test this:

See if the logging goes away.

Confirm that download still works.

Confirm that guestbooks still work.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No.

Is there a release notes update needed for this change?:

Yes, added.

Additional documentation:

No.

@pdurbin pdurbin added this to the 6.0 milestone Aug 30, 2023
@coveralls
Copy link

Coverage Status

coverage: 19.969%. remained the same when pulling f30316d on 9806-logging into ed81893 on develop.

@scolapasta scolapasta self-assigned this Aug 31, 2023
@landreev
Copy link
Contributor

landreev commented Sep 6, 2023

So what did we decide to do with this PR, did you say that we are closing it, now that the original logging noise issue has been solved?

@pdurbin
Copy link
Member Author

pdurbin commented Sep 6, 2023

@landreev yes, that's my understanding (#9867 fixed it). Closing. We can always re-open it or steal parts of it for a new PR.

@pdurbin pdurbin closed this Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Payara 6: When downloading a file with tou/guestbook enabled, works but throws server log error.

4 participants