Conversation
pdurbin
approved these changes
Sep 5, 2023
Member
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
I didn't test this but Gustavo said it works and the change seems reasonable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
reduces noise in log 🎉
Which issue(s) this PR closes:
Closes #9806
Special notes for your reviewer:
Please make sure I didn't miss any of the "actions". (I missed two of them in my first commit)
Suggestions on how to test this:
try to download a file with guestbook enabled and confirm no error in log. There were 10 places the code changed, so ideally confirm the different paths - these include tabular vs non tabular, globus, package, explore tools, etc. Each way has a different link. I'm pretty sure the same fix is correct for all, so alternatively, also look at code to confirm I got them all.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
no
Is there a release notes update needed for this change?:
no
Additional documentation: