Fix regular markdown link generation #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for looking into this! Merging it into a branch first so that I can make some code style changes, but otherwise looks good! |
Merged
Owner
|
PR has been merged to master as part of #33, thanks for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regular markdown links are broken, and this fixes it.
To verify that it was indeed broken before this patch, simply make nested folders (with folder notes) with waypoints. You can see that its broken in graph view, or simply by clicking the links (itll complain about folder existing rather than bring you to the file)
I’ll probably open another PR for unit testing and a little more refactoring for this function.