Skip to content

Conversation

@Mara-Li
Copy link

@Mara-Li Mara-Li commented Aug 4, 2022

I merged the two PR (#31 and #24) and also made a support for folder note "outside" strategies.
This PR is an attempt to fix the #19 issue.

@IdreesInc
Copy link
Owner

Sorry for the delay on reviewing these PRs, life has gotten in the way these past few months. After trying out this fork on my sample vault, I am unable to get the features to work as expected and am running into a few different exceptions. I'm going to look into this further and see if I can take a crack at the outside folder strategy. I'm also going to merge in #31 separately since I need to make a few changes to that code before adding it to master. Thank your for taking the time to go through these PRs and cleaning up the code!

@IdreesInc
Copy link
Owner

Outside folder notes have now been added as part of #35, thanks once more for bringing this to my attention along with possible solutions

@Mara-Li
Copy link
Author

Mara-Li commented Aug 5, 2022

That you for this reply ! I'm happy that now the plugin support outside strategy :)

@Mara-Li Mara-Li closed this Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants