fix(cli-templetes): Replaced index.html <title> to ApplicationTitle as placeholder#1237
Merged
fix(cli-templetes): Replaced index.html <title> to ApplicationTitle as placeholder#1237
Conversation
…emplate index.html <title> to ApplicationTitle as placeholder
ivanvpetrov
added
❌ status: awaiting-test
templates
onlyexeption
reviewed
Apr 9, 2024
onlyexeption
reviewed
Apr 9, 2024
Contributor
|
please use camelCase across your changes |
…from base (with the <%=ApplicationTitle%> placeholder) so that it won't leak to other templates
onlyexeption
approved these changes
Apr 10, 2024
gedinakova
approved these changes
Apr 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced React's, Web Component's and Angular's template index.html <title> to ApplicationTitle as placeholder