Skip to content

fix(cli-templetes): Replaced index.html <title> to ApplicationTitle as placeholder #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lipata merged 3 commits into from
Apr 11, 2024
Merged

fix(cli-templetes): Replaced index.html <title> to ApplicationTitle as placeholder #1237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c946766
fix(cli-templetes): Replaced React's, Web Component's and Angular's t…
ivanvpetrov Apr 8, 2024
c2e900a
fix(cli-templetes): React. Added index.html file to override the one …
ivanvpetrov Apr 10, 2024
93dc491
Merge branch 'master' into IPetrov/30534-fix
gedinakova Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli/templates/react/igr-ts/projects/_base/files/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
content="width=device-width, initial-scale=1, shrink-to-fit=no"
/>
<meta name="theme-color" content="#000000" />
<title>IgniteUI for React</title>
<title><%=ApplicationTitle%></title>
<link rel="stylesheet" href="./styles.css">
</head>
<body>
Expand Down
29 changes: 29 additions & 0 deletions packages/cli/templates/react/igr-ts/projects/_base_with_home/files/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8" />
<link rel="shortcut icon" href="/favicon.ico" />
<meta
name="viewport"
content="width=device-width, initial-scale=1, shrink-to-fit=no"
/>
<meta name="theme-color" content="#000000" />
<title>IgniteUI for React</title>
<link rel="stylesheet" href="./styles.css">
</head>
<body>
<noscript>You need to enable JavaScript to run this app.</noscript>
<div id="root"></div>
<!--
This HTML file is a template.
If you open it directly in the browser, you will see an empty page.

You can add webfonts, meta tags, or analytics to this file.
The build step will place the bundled scripts into the <body> tag.

To begin the development, run `npm start` or `yarn start`.
To create a production bundle, use `npm run build` or `yarn build`.
-->
</body>
<script type="module" src="/src/main.tsx"></script>
</html>
2 changes: 1 addition & 1 deletion packages/cli/templates/webcomponents/igc-ts/projects/_base/files/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<head>
<meta charset="utf-8">
<base href="/">
<title>Ignite UI for Web Components</title>
<title><%=ApplicationTitle%></title>
<link rel="stylesheet" href="./styles.css">
</head>

Expand Down
3 changes: 2 additions & 1 deletion packages/igx-templates/igx-ts-legacy/projects/_base/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,8 @@ $app-palette: palette($primary, $secondary, $surface);
dot: ".",
path: name,
projectTemplate: this.id,
yamlDefaultBranch: "<%=yaml-default-branch%>" // the placeholder will be evaluated by CodeGen
yamlDefaultBranch: "<%=yaml-default-branch%>", // the placeholder will be evaluated by CodeGen
ApplicationTitle: "<%=ApplicationTitle%>" // the placeholder will be evaluated by CodeGen
};

switch (theme) {
Expand Down
2 changes: 1 addition & 1 deletion packages/igx-templates/igx-ts-legacy/projects/base/files/src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<html lang="en">
<head>
<meta charset="utf-8">
<title>Ignite UI for Angular</title>
<title><%=ApplicationTitle%></title>
<base href="/">

<meta name="viewport" content="width=device-width, initial-scale=1">
Expand Down
3 changes: 2 additions & 1 deletion packages/igx-templates/igx-ts/projects/_base/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,8 @@ $app-palette: palette($primary, $secondary, $surface);
dot: ".",
path: name,
projectTemplate: this.id,
yamlDefaultBranch: "<%=yaml-default-branch%>" // the placeholder will be evaluated by CodeGen
yamlDefaultBranch: "<%=yaml-default-branch%>", // the placeholder will be evaluated by CodeGen
ApplicationTitle: "<%=ApplicationTitle%>" // the placeholder will be evaluated by CodeGen
};

switch (theme) {
Expand Down
2 changes: 1 addition & 1 deletion packages/igx-templates/igx-ts/projects/base/files/src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<html lang="en">
<head>
<meta charset="utf-8">
<title>Ignite UI for Angular</title>
<title><%=ApplicationTitle%></title>
<base href="/">

<meta name="viewport" content="width=device-width, initial-scale=1">
Expand Down