Skip to content

[algorithm] Refactor PR #1 - SPtr in place of raw pointers #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
epernod merged 2 commits into from
Aug 7, 2025
Merged

[algorithm] Refactor PR #1 - SPtr in place of raw pointers #47

epernod merged 2 commits into from
Aug 7, 2025

Conversation

@th-skam
Copy link
Collaborator

@th-skam th-skam commented Aug 5, 2025

Info & Merging

  • A series of PRs to clean-up and simplify the algorithm, and make it easier to make additions in the future.
  • Suggest to squash-merge each PR into the dev-refactor branch and then rebase-merge that into the master branch.

Changes

  • Storing pointers from SOFA node context getters into shared pointers.
  • const qualifiers for SPtr variables that do not change

@th-skam th-skam mentioned this pull request Aug 5, 2025
Merged
@th-skam th-skam added the pr: status to review To notify reviewers to review this pull-request label Aug 5, 2025
@th-skam th-skam mentioned this pull request Aug 5, 2025
Merged
@epernod epernod merged commit 64d8c5b into dev-refactor Aug 7, 2025
@epernod epernod deleted the rework1-sptr branch August 7, 2025 09:39
@th-skam th-skam restored the rework1-sptr branch August 7, 2025 12:45
@th-skam th-skam deleted the rework1-sptr branch August 7, 2025 12:48
This was referenced Aug 8, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@epernod epernod epernod approved these changes

Assignees

No one assigned

Labels

pr: clean pr: enhancement pr: status to review To notify reviewers to review this pull-request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@th-skam @epernod