Skip to content

[algorithm] Refactor PR #2 - References to access containers - avoid copies #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
th-skam merged 1 commit into from
Aug 7, 2025
Merged

[algorithm] Refactor PR #2 - References to access containers - avoid copies #48

th-skam merged 1 commit into from
Aug 7, 2025

Conversation

@th-skam
Copy link
Collaborator

@th-skam th-skam commented Aug 5, 2025

Info & Merging

  • A series of PRs to clean-up and simplify the algorithm, and make it easier to make additions in the future.
  • Suggest to squash-merge each PR into the dev-refactor branch and then rebase-merge that into the master branch.

Dependencies

Changes

  • Switch to using references to avoid copies for containers

@th-skam th-skam added pr: clean pr: enhancement pr: status to review To notify reviewers to review this pull-request labels Aug 5, 2025
@th-skam th-skam mentioned this pull request Aug 5, 2025
Merged
@th-skam th-skam added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Aug 7, 2025
@th-skam th-skam changed the base branch from dev-refactor to master August 7, 2025 12:50
@th-skam th-skam merged commit df8a37f into master Aug 7, 2025
@th-skam th-skam deleted the rework2-refs branch August 7, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@epernod epernod epernod approved these changes

Assignees

No one assigned

Labels

pr: clean pr: enhancement pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@th-skam @epernod