Skip to content

[algorithm] Refactor PR #3 - Add sanity checks and failproof #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
epernod merged 8 commits into from
Aug 7, 2025
Merged

[algorithm] Refactor PR #3 - Add sanity checks and failproof #49

epernod merged 8 commits into from
Aug 7, 2025

Conversation

@th-skam
Copy link
Collaborator

@th-skam th-skam commented Aug 5, 2025 •
edited
Loading

Info & Merging

  • A series of PRs to clean-up and simplify the algorithm, and make it easier to make additions in the future.

Dependencies

Changes

  • Checks added for acceptable threshold values and pointer validity of the constraint solver
  • Use the m_couplingPts container as an indicator on whether the algorithm is in the puncture or insertion phase

@th-skam th-skam added pr: enhancement pr: status to review To notify reviewers to review this pull-request labels Aug 5, 2025
@th-skam th-skam mentioned this pull request Aug 5, 2025
Merged
@th-skam th-skam changed the base branch from dev-refactor to master August 7, 2025 12:52
th-skam added 4 commits August 7, 2025 14:53
@th-skam
[algorithm] check whether a constraint solver is found in the context…
a4cd7e6 
… at init
@th-skam
[algorithm] check whether user provided acceptable values for thresho…
406ce5d 
…lds used by the algorithm
@th-skam
[algorithm] sum all lambda values applied on the tipGeom mstate
3559b9d 
Still better to iterate and sum than accessing the first value (->[0]). It also
makes sense in case one defines the tip as a collection of points (in case the
needle has thickness).
@th-skam
[algorithm] Distinguish execution flow between puncture and insertion…
269e72c 
… based on m_couplingPts.empty
@th-skam th-skam force-pushed the rework3-sanity-checks branch from 4dd0fbc to 269e72c Compare August 7, 2025 12:53
@th-skam th-skam requested a review from epernod August 7, 2025 12:54
epernod
epernod requested changes Aug 7, 2025
View reviewed changes
th-skam and others added 4 commits August 7, 2025 15:46
@th-skam @epernod
Apply changes #1
5ed212d 
Co-authored-by: erik pernod <erik.pernod@gmail.com>
@th-skam @epernod
Apply changes #2
4035470 
Co-authored-by: erik pernod <erik.pernod@gmail.com>
@th-skam @epernod
Apply changes #3
103ce9e 
Co-authored-by: erik pernod <erik.pernod@gmail.com>
@th-skam @epernod
Apply change #4 - Style
3fab4a6 
Co-authored-by: erik pernod <erik.pernod@gmail.com>
@th-skam th-skam requested a review from epernod August 7, 2025 13:48
@epernod epernod merged commit e4ab9eb into master Aug 7, 2025
@epernod epernod deleted the rework3-sanity-checks branch August 7, 2025 13:50
@th-skam th-skam mentioned this pull request Aug 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@epernod epernod epernod approved these changes

Assignees

No one assigned

Labels

pr: enhancement pr: status to review To notify reviewers to review this pull-request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@th-skam @epernod