Skip to content

[algorithm] Refactor PR #4 - Proper iterator use #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
epernod merged 1 commit into from
Aug 7, 2025
Merged

[algorithm] Refactor PR #4 - Proper iterator use #50

epernod merged 1 commit into from
Aug 7, 2025

Conversation

@th-skam
Copy link
Collaborator

@th-skam th-skam commented Aug 5, 2025 •
edited
Loading

Info & Merging

  • A series of PRs to clean-up and simplify the algorithm, and make it easier to make additions in the future.

Dependencies

Changes

  • Avoid copying proximities and pass sptr during push-back to the couplingPts container
  • Clear the insertionOutput list at the start of every time-step unconditionally. More proper for removal of points when retreating the needle.
  • Simplify algorithm parts - reduce length

@th-skam th-skam added pr: clean pr: status to review To notify reviewers to review this pull-request labels Aug 5, 2025
@th-skam th-skam changed the base branch from master to dev-refactor August 5, 2025 09:12
@th-skam th-skam mentioned this pull request Aug 5, 2025
Merged
@th-skam th-skam changed the base branch from dev-refactor to master August 7, 2025 12:53
@th-skam th-skam force-pushed the rework4-algorithm branch from 721fa75 to 25170d5 Compare August 7, 2025 13:58
epernod
epernod reviewed Aug 7, 2025
View reviewed changes
@epernod epernod added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Aug 7, 2025
@epernod epernod merged commit 5c8f27f into master Aug 7, 2025
@epernod epernod deleted the rework4-algorithm branch August 7, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@epernod epernod epernod approved these changes

Assignees

No one assigned

Labels

pr: clean pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@th-skam @epernod