Skip to content

Conversation

@th-skam
Copy link
Collaborator

@th-skam th-skam commented Aug 5, 2025

Info & Merging

  • A series of PRs to clean-up and simplify the algorithm, and make it easier to make additions in the future.

Dependencies

Changes

  • The needlePts variable is not needed since the algorithm re-projects proximities on the needle shaft at every time step.

@th-skam th-skam added pr: clean pr: enhancement pr: status to review To notify reviewers to review this pull-request labels Aug 5, 2025
@th-skam th-skam changed the base branch from dev-refactor to master August 7, 2025 12:53
@th-skam th-skam force-pushed the rework5-remove-needlePts branch from 6248993 to deaea6a Compare August 7, 2025 14:45
Copy link
Contributor

@epernod epernod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you introduce the m_needlePts or was it already there?

@th-skam
Copy link
Collaborator Author

th-skam commented Aug 7, 2025

The m_needlePts was introduced by me. At that time, we were storing the proximities on the needle. Now, we are re-projecting the proximities stored in m_couplingPts back on the needle geometry. There is no need to store them because we re-compute them at every time step and do a push back at the insertionOutput in place.

Co-authored-by: erik pernod <erik.pernod@gmail.com>
@epernod epernod added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Aug 7, 2025
@epernod epernod merged commit c186962 into master Aug 7, 2025
@epernod epernod deleted the rework5-remove-needlePts branch August 7, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: clean pr: enhancement pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants