[algorithm] Refactor PR #6 - Rework order of removal/addition of coupling points

[th-skam]

Info & Merging

• A series of PRs to clean-up and simplify the algorithm, and make it easier to make additions in the future.
• Suggest to squash-merge each PR into the dev-refactor branch and then rebase-merge that into the master branch.

Dependencies

• After PR [algorithm] Refactor PR #5 - Remove needlePts variable #51

Changes

• The removal and addition of coupling points should be exclusive with respect to one another (within the same time step). With this PR, we first check whether a coupling point should be added and, only in case it does not, we check whether it should be removed. This avoids an inconsistent scenario where a point could both be added and removed as the two checks could be true at the same time.

[epernod]

I checked in the full method code, this is not the case here, but just FYI, if possible, .getValue() should not be called inside a for loop because they imply some memory access that the compilator can't optimize (due to the Data container code etc...)

So it is better to do:

const auto& data = d_data.getValue();
for (;;)
{
   mycheck(value, data);
}

[th-skam]

Ah yes, that rings a bell. I'll actually adjust this in the next PR 'cause it's a good tip.