Skip to content

Conversation

@th-skam
Copy link
Collaborator

@th-skam th-skam commented Aug 5, 2025

Info & Merging

  • A series of PRs to clean-up and simplify the algorithm, and make it easier to make additions in the future.

Dependencies

Changes

  • Changed the order of operations during the puncture phase. Before checking whether the punctureThreshold is surpassed, a new surface proximity is first detected. This new proximity should be used to couple the needle and not the one determined in the previous step. This approach should be more consistent because the animation loop has already displaced the needle as if there was a collision with the surface before the doDetection() function was called again.
  • The re-projection of coupling points on the needle now takes place at the end of doDetection(), accounting for any previous modification to the list of coupling points.

@th-skam th-skam added pr: clean pr: enhancement pr: status to review To notify reviewers to review this pull-request labels Aug 5, 2025
@th-skam th-skam changed the base branch from dev-refactor to master August 7, 2025 12:54
@th-skam th-skam force-pushed the rework7-algorithm-logic branch from aba6c42 to 128d306 Compare August 8, 2025 11:04
@th-skam th-skam requested a review from epernod August 8, 2025 11:05
@th-skam th-skam mentioned this pull request Aug 8, 2025
6 tasks
Co-authored-by: erik pernod <erik.pernod@gmail.com>
@epernod epernod merged commit 746b1b3 into master Aug 8, 2025
@epernod epernod deleted the rework7-algorithm-logic branch August 8, 2025 12:58
@epernod epernod added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Aug 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: clean pr: enhancement pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants